-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine tensor transform interface #170
Conversation
Now only overload A consequence is that the default fallback transform of using Vandermonde+LeastSquares creates the grid twice. Whooptydoo. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 91.59% 91.69% +0.10%
==========================================
Files 11 11
Lines 761 783 +22
==========================================
+ Hits 697 718 +21
- Misses 64 65 +1 ☔ View full report in Codecov by Sentry. |
This refines the tensor transform interface. In particular:
grid(P)
andgrid(P,n::Int)
return just a vector of pointsgrid(P, (n,))
,grid(P, (m,n))
etc. return a tuple of vectors of points in each dimension.plan_grid_transform
.Thus one can do a 1D transform that gets out at least 5 coefficients via eg:
or a 2D transform
Note the "1D" and "2D" don't necessarily mean dimension of the geometry, eg, when combined with MultivariateOrthogonalPolynomials.jl the interface of a tensor product of disks would be:
@TSGut this might be of use for you.