Refactor model scitype check2 #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## for-a-0-point-20-release #732 +/- ##
===========================================================
Coverage ? 85.06%
===========================================================
Files ? 36
Lines ? 3369
Branches ? 0
===========================================================
Hits ? 2866
Misses ? 503
Partials ? 0 Continue to review full report at Codecov.
|
|
This looks good! I had figured the main issue was in the tests where we were checking for the presence of various log messages. I just checkout out your branch and ran through all the tests without issue! Thanks for helping me along here! |
pazzo83
approved these changes
Jan 28, 2022
…an-turing-institute/MLJBase.jl into refactor_model_scitype_check2
|
@pazzo83 I've rebased this PR onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #731.
Needs:
@pazzo83 Be good if you review this (the most recent commits). The main problems fixed in this continuation are:
fit_data_scitypefor supervised models supporting weights (so not part of this PR, but partly responsible for failure of tests in remove specific model checks for general scitype check #731)Unknowninfit_data_scitype. This is now a separate function_contains_unknownwith tests.check_model_scitypewas not returning the value ofnowarnsThe difficulties encountered in #731 are due in some part to a lack of testing of the
check_model_scitype"fallback" we are now using as the main method. The methods we are removing were covering up this lack of testing, but that's a poor excuse. My apologies for this.To do:
for-a-0-point-20-release. Technically, the only "breaking" change is changes to strings in the warnings. However, I think these changes are pretty critical for new users, for which the new warnings will be more cryptic. So, we may want to at least wait for some progress on [Discussion] Review model documentation strings MLJ.jl#898 before releasing the changes here. @pazzo83 You could continue development of "supervised" transformers using thefor-a-0-point-20-releasebranch? This is being regularly rebased onto dev. What do you think?