-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 208 project submissions scoring ui #217
Closed
susham
wants to merge
57
commits into
JoyOfCodingPDX:master
from
susham:issue-208-project-submissions-scoring-ui
Closed
Issue 208 project submissions scoring ui #217
susham
wants to merge
57
commits into
JoyOfCodingPDX:master
from
susham:issue-208-project-submissions-scoring-ui
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed some better error checking for the score entered by the Grader.
…ctored some common field validation code.
…l the uncaught exception handler in the project submission scorer application.
…. There's no need to do so.
…been set yet, give it full credit (max points).
…ring-ui Demonstrate that Susham can get his code into my repository.
…oring-ui' into issue-208-project-submissions-scoring-ui
…s-scoring-ui Issue 208 project submissions scoring ui
…s-scoring-ui Get upstream changes from Dave
…mission XML files.
…es from which they were loaded.
@susham, instead of making a Pull Request against my That way, the Pull Request will only contain the changes made on your branch, not all of the changes that have been made (by you and me) to support issue #208. It will help me focus on providing you with feedback on your changes. |
…s-scoring-ui Get latest changes from DavidWhitlock's issue 208 branch
Let's use #218 to track these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review for Implementation of ProjectSubmissionOutputFileParser