mpflash: Fix macOS specific ports scanning issues #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
=======================================
Coverage 78.67% 78.67%
=======================================
Files 68 68
Lines 5683 5683
Branches 899 899
=======================================
Hits 4471 4471
Misses 905 905
Partials 307 307
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
85e598b to
060a451
Compare
Modify the `filtered_comports` function in `src/mpflash/mpflash/common.py` to exclude non-microcontroller ports based on descriptions and hardware ID patterns. * Exclude ports with descriptions containing "debug-console" on MacOS / Darwin. * Add logic to exclude bluetooth ports on MacOS / Darwin. * Add tests for MacOS ports filtering. Signed-off-by: Jos Verlinde <Jos.Verlinde@microsoft.com>
060a451 to
2cf90b9
Compare
Signed-off-by: Jos Verlinde <Jos.Verlinde@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the
filtered_comportsfunction insrc/mpflash/mpflash/common.pyto exclude non-microcontroller ports based on descriptions and hardware ID patterns.Add tests for the changed functionality in
src/mpflash/tests/test_filtered_comports.py.