Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in get-frozen when using version=latest #442

Merged
merged 3 commits into from
Nov 4, 2023

Conversation

samskiter
Copy link
Contributor

Return from match_lib_with_mpy when checking out 'latest'

Return from match_lib_with_mpy when checking out 'latest'
@samskiter samskiter requested a review from Josverl as a code owner October 31, 2023 08:59
Copy link
Owner

@Josverl Josverl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, however Bool should be bool to avoid
E NameError: name 'Bool' is not defined

Can you please update to : def match_lib_with_mpy(version_tag: str, lib_path: Path) -> bool:

that should clear the error in the CI tests

@samskiter
Copy link
Contributor Author

Thanks, looks good, however Bool should be bool to avoid E NameError: name 'Bool' is not defined

Can you please update to : def match_lib_with_mpy(version_tag: str, lib_path: Path) -> bool:

that should clear the error in the CI tests

done

@Josverl Josverl merged commit 7fab7c0 into Josverl:main Nov 4, 2023
3 of 4 checks passed
@Josverl
Copy link
Owner

Josverl commented Nov 4, 2023

@all-contributors please add @samskiter for test
@all-contributors please add @samskiter for code

Copy link
Contributor

@Josverl

I've put up a pull request to add @samskiter! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants