add rust version and MSRV CI #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eitsupi
reviewed
Jan 24, 2024
Co-authored-by: eitsupi <50911393+eitsupi@users.noreply.github.com>
|
thanks @eitsupi !!! |
|
Yeah, now (and I don't know when it will be updated) Rust on CRAN is 1.69.0, so it is clear that R packages that incorporate this crate cannot be registered on CRAN :) |
|
loool. well! When i try publishing my R package using this i'll try and make my case 🙏🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
Adds Rust version to
Cargo.tomlbased on upstream arrow-rs version:https://github.com/apache/arrow-rs/blob/a0148ba4cea1756bd22c534dff14e362cb5ee242/Cargo.toml#L77C1-L77C22
Adds simple MSRV check in CI