-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organise and clean #25
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
Accidentally used the branch to create infrastructure. Made a script to auto-dockerise and push containers to AWS. Added a workflow to automate this after every push to git, and corresponding badge in README. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good, great that the CI/CD pipeline works very well
@@ -46,7 +56,7 @@ If you are having trouble using our app please open a ticket we'll get back to y | |||
|
|||
## Authors and Acknowledgment | |||
|
|||
If people have pushed to this repo, they are authors! | |||
If people have pushed to this repo, they are authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change, I think it is a nice change in tone
@@ -20,6 +29,7 @@ Run the following commands: | |||
- `python3 -m venv .venv` | |||
- `bash setup.sh` ! we might want a simple setup script ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the ! ... ! to do
Created an infrastructure directory to put IaS code into.
Update:
Accidentally used the branch to create infrastructure..
Made a script to auto-dockerise and push containers to AWS.
Added a workflow to automate this after every push to git (IF tests are passed), and corresponding badge in README.