Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organise and clean #25

Merged
merged 55 commits into from
Aug 20, 2024
Merged

Organise and clean #25

merged 55 commits into from
Aug 20, 2024

Conversation

JoshuaMarden
Copy link
Owner

@JoshuaMarden JoshuaMarden commented Aug 20, 2024

Created an infrastructure directory to put IaS code into.

Update:

Accidentally used the branch to create infrastructure..

Made a script to auto-dockerise and push containers to AWS.

Added a workflow to automate this after every push to git (IF tests are passed), and corresponding badge in README.

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
pytest 68.33% <ø> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@JoshuaMarden
Copy link
Owner Author

Accidentally used the branch to create infrastructure.

Made a script to auto-dockerise and push containers to AWS.

Added a workflow to automate this after every push to git, and corresponding badge in README.

Copy link
Collaborator

@HighestAuto HighestAuto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, great that the CI/CD pipeline works very well

@@ -46,7 +56,7 @@ If you are having trouble using our app please open a ticket we'll get back to y

## Authors and Acknowledgment

If people have pushed to this repo, they are authors!
If people have pushed to this repo, they are authors.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, I think it is a nice change in tone

@@ -20,6 +29,7 @@ Run the following commands:
- `python3 -m venv .venv`
- `bash setup.sh` ! we might want a simple setup script !
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the ! ... ! to do

@HighestAuto HighestAuto merged commit 55d467c into main Aug 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants