Extract unittests #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 16, 2024 16:31
HighestAuto
approved these changes
Aug 19, 2024
| @@ -52,7 +52,7 @@ def fetch_data(self) -> Optional[Dict[str, Any]]: | |||
| response.raise_for_status() | |||
| return response.json() | |||
| except requests.exceptions.RequestException as e: | |||
| self.logger.error(f"An error occurred: {e}") | |||
| self.logger.error("An error occurred: %s", e) | |||
There was a problem hiding this comment.
Nice updating all logs to use %s
| self.logger.info("\n" + df.head().to_string()) | ||
| self.logger.info("Time Period of Data:") | ||
| self.logger.info(time_period) | ||
| self.logger.debug("DataFrame of Demand Data:\n%s", df.to_string()) |
There was a problem hiding this comment.
Great reduction in Logging!
| psycopg2 | ||
| python-dotenv | ||
| datetime | ||
| anyio==4.4.0 |
There was a problem hiding this comment.
This brings up the question of getting the latest version of a product vs keeping the same version constantly. I don't know which answer is correct in this case. Ask the stakeholders?
|
|
||
| from tests.mock_data.mock_dataframes import get_dated_mock_dataframe | ||
| api_client_carbon.logger.error.assert_called_once_with("An error occurred: %s", mock_get.side_effect) |
There was a problem hiding this comment.
Great catch of deleting the extra imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds automated testing plus a badge.
Also adds a licence that can be linked-to by a badge.