fix: exclude tests with.npmignore #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay think this is good! |
JoshuaKGoldberg
approved these changes
Aug 24, 2024
There was a problem hiding this comment.
Yup, this is great - thanks!
I was actually a little surprised at first it's passing build, there are no unit test changes... But all is well:
- Unit tests: I never added snapshots for
rootFiles.tsbecause they'd be super verbose. - End-to-end tests: the migration one is verifying that the
.npmignoreon disk matches what's created
✅ great!
|
🎉 This is included in version v1.71.4 🎉 The release is available on: Cheers! 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Doing this on a mobile phone on a train. It can never work, can it?