Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unnecessary devDependencies for --base common #1636

Merged
merged 2 commits into from
Aug 15, 2024
Merged

fix: remove unnecessary devDependencies for --base common #1636

merged 2 commits into from
Aug 15, 2024

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 15, 2024 •
edited
Loading

PR Checklist

Overview

Adds options.* checking in finalizeDependencies, to better restrict what gets installed.

💖

@JoshuaKGoldberg JoshuaKGoldberg merged commit a556755 into main Aug 15, 2024
13 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the common-excludes branch August 15, 2024 16:14
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.71.1 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Bug: 'common' preset has knip errors upon creation
1 participant
@JoshuaKGoldberg