Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct remaining --auto mismatches #1612

Merged
merged 19 commits into from
Aug 11, 2024
Merged

Conversation

JoshuaKGoldberg
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg commented Aug 11, 2024

PR Checklist

Overview

Fills in a lot of logic around defaults that was previously not hooked up. --auto now completely works as expected in this repository.

💖

Copy link

codecov bot commented Aug 11, 2024

Codecov Report

Attention: Patch coverage is 98.36066% with 2 lines in your changes missing coverage. Please review.

Project coverage is 97.77%. Comparing base (d502d3e) to head (2f2e3ed).
Report is 115 commits behind head on main.

Files Patch % Lines
.../shared/options/createOptionDefaults/index.test.ts 97.95% 1 Missing ⚠️
src/shared/options/createOptionDefaults/index.ts 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1612      +/-   ##
==========================================
- Coverage   98.09%   97.77%   -0.32%     
==========================================
  Files         102      174      +72     
  Lines        5764     9728    +3964     
  Branches      491      953     +462     
==========================================
+ Hits         5654     9512    +3858     
- Misses        109      215     +106     
  Partials        1        1              
Flag Coverage Δ
create 70.83% <38.09%> (+0.11%) ⬆️
initialize 44.32% <59.52%> (+0.01%) ⬆️
migrate 71.65% <61.90%> (+0.98%) ⬆️
unit 90.50% <98.30%> (+11.99%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: use --auto in end-to-end migration test fix: correct remaining --auto mismatches Aug 11, 2024
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review August 11, 2024 03:45
@JoshuaKGoldberg JoshuaKGoldberg merged commit 551737a into main Aug 11, 2024
13 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the e2e-migrate-auto branch August 11, 2024 03:50
Copy link

🎉 This is included in version v1.67.3 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant