Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Run initialize command (script) in e2e test #1186

Closed
3 tasks done
JoshuaKGoldberg opened this issue Jan 3, 2024 · 1 comment · Fixed by #1187
Closed
3 tasks done

🛠 Tooling: Run initialize command (script) in e2e test #1186

JoshuaKGoldberg opened this issue Jan 3, 2024 · 1 comment · Fixed by #1187
Assignees
@JoshuaKGoldberg
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(

Comments

@JoshuaKGoldberg
Copy link
Owner

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

#1168 was able to happen because nothing in the repo's testing actually runs pnpm run initialize. I should

Additional Info

No response
@JoshuaKGoldberg JoshuaKGoldberg added area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! labels Jan 3, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Jan 3, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the type: bug Something isn't working :( label Jan 3, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jan 3, 2024
Merged
3 tasks
JoshuaKGoldberg added a commit that referenced this issue Jan 4, 2024
@JoshuaKGoldberg @johnnyreilly @Aslemammad
docs: overhaul for scripts and their end-to-end tests (#1187)
6f58d7f 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1141; fixes #1186
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

Adds some inline comments to end-to-end tests, as well as a more full
description of what to do with migration snapshots in development docs.
Also simplifies the migration test error to suggest looking at the docs.

Touches a little bit on what #1045 requests around more clear and
standardized token docs.

Co-authored-by: John Reilly <johnny_reilly@hotmail.com>
Co-authored-by: Mohammad Bagher Abiyat <zorofight94@gmail.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2024

🎉 This is included in version v1.52.7 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: bug Something isn't working :(
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: overhaul for scripts and their end-to-end tests JoshuaKGoldberg/create-typescript-app
1 participant
@JoshuaKGoldberg