Add possibility to cache dns lookups #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8638431 to
140f2ff
Compare
JoshData
reviewed
Nov 15, 2020
Add optional argument dns_resolver to validate_email. If provided it will be used instead of the default resolver. The provided resolver can have a configured cache and custom timeout.
Example usage:
dns_resolver = dns.resolver.Resolver()
dns_resolver.cache = dns.resolver.Cache()
dns_resolver.timeout = 10
valid = validate_email("test@gmail.com", dns_resolver=dns_resolver)
140f2ff to
c4f0e89
Compare
HeyHugo
commented
Nov 15, 2020
|
Excellent. This is basically what I was thinking. I made some tweaks. If you think it's OK, I'll merge. Happy to keep discussing otherwise. |
c9e5547 to
7527a97
Compare
Codecov Report
@@ Coverage Diff @@
## primary #58 +/- ##
===========================================
+ Coverage 83.77% 84.12% +0.34%
===========================================
Files 1 1
Lines 228 233 +5
===========================================
+ Hits 191 196 +5
Misses 37 37
Continue to review full report at Codecov.
|
|
Nice! Good with the helper function. Looks good. I fixed linting so lint checks pass. |
|
Thanks! |
|
The DNS resolve cache is great. Any ETA for when this will get pushed to pypi? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional argument dns_resolver to validate_email. If provided it will be used instead of the default resolver. The provided resolver can have a configured cache and custom timeout. Closes #55
Example usage: