#14 Implement notification cancellation #15

basilevs · 2023-10-13T21:07:47Z

Fixes #14

This introduces a way for user to cancel previously sent notification.
The implementation is naive and dirty - no threading or processes involved, notification is cancelled by its ID.

I've tried a "proper" solution with remote controlled singular side-car process, but found, that this is much simpler, as actual notification object is not needed to cancel it, and cancellation is a non-blocking operation.

Usage example:

from mac_notifications.client import create_notification, Notification 
mac_notification: Notification = None
def set_network_status(message):
    global mac_notification
    if mac_notification:
        mac_notification.cancel()
        mac_notification = None
    if message:
        mac_notification = create_notification(title="Network status", text=message)

set_network_status("Router is unavailable")
set_network_status(None) #Nominal
set_network_status("Domain name server is unavailable")

Jorricks · 2023-10-31T20:15:46Z

Hello @basilevs,
Thanks a lot that you took the time to implement this, that's amazing!
I like your implementation, it's clear and easy. I just have some typing 'complaints', which I added as suggestions to this MR.
Let's get this out in a new version soon ✌️

basilevs · 2023-11-01T13:07:32Z

some typing 'complaints', which I added as suggestions to this MR.

I don't see the suggestion make sure you've posted them (they are organized in reviews and are only published when the review is published)

Jorricks

Woops. I use Gitlab during the day so sometimes it's a bit searching on Github. Thanks for the pointer ✌️

Jorricks · 2023-10-31T20:10:01Z

examples/cancel_multiple_notifications.py

+if __name__ == "__main__":
+    print("Sending meeting notification.")
+
+    sent: [Notification] = [] 


I don't think this is correct Python3.8 syntax.

Suggested change

sent: [Notification] = []

sent: List[Notification] = []

We also need to add the from typing import List

Fixed with list builtin

Jorricks · 2023-10-31T20:11:39Z

src/mac_notifications/notification_sender.py

@@ -107,3 +106,9 @@ def userNotificationCenter_didActivateNotification_(

    # return notification
    return new_notif
+
+
+def cancel_notification(uid:str):


Suggested change

def cancel_notification(uid:str):

def cancel_notification(uid: str) -> None:

Jorricks · 2023-10-31T20:11:52Z

src/mac_notifications/manager.py

@@ -30,6 +31,15 @@
 logger = logging.getLogger()


+class Notification(object):
+    def __init__(self, uid):


Suggested change

def __init__(self, uid):

def __init__(self, uid: str) -> None:

Jorricks · 2023-10-31T20:12:03Z

src/mac_notifications/manager.py

+    def __init__(self, uid):
+        self.uid = uid
+
+    def cancel(self):


Suggested change

def cancel(self):

def cancel(self) -> None:

Jorricks · 2023-10-31T20:12:41Z

src/mac_notifications/manager.py

@@ -12,6 +12,7 @@
 from mac_notifications.listener_process import NotificationProcess
 from mac_notifications.notification_config import NotificationConfig
 from mac_notifications.singleton import Singleton
+from .notification_sender import cancel_notification


Suggested change

from .notification_sender import cancel_notification

from mac_notifications import notification_sender

Replaced with

from mac_notifications.notification_sender import cancel_notification

Jorricks · 2023-10-31T20:13:23Z

src/mac_notifications/manager.py

+        self.uid = uid
+
+    def cancel(self):
+        cancel_notification(self.uid)


Suggested change

cancel_notification(self.uid)

notification_sender.cancel_notification(self.uid)

basilevs · 2023-11-03T18:12:25Z

All suggestions have been acted upon

Jorricks

Looks good. Let's merge it :)

basilevs added 2 commits October 14, 2023 01:00

Jorricks#14 Cancel notifications feature

df69b23

Add missing EOL

7e260a8

Jorricks reviewed Nov 1, 2023

View reviewed changes

Fix typing and import styles Jorricks#14

65f49fe

Jorricks approved these changes Feb 4, 2024

View reviewed changes

Jorricks merged commit 76dbd33 into Jorricks:main Feb 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#14 Implement notification cancellation #15

#14 Implement notification cancellation #15

basilevs commented Oct 13, 2023 •

edited

Loading

Jorricks commented Oct 31, 2023

basilevs commented Nov 1, 2023

Jorricks left a comment

Jorricks Oct 31, 2023

Jorricks Oct 31, 2023

basilevs Nov 3, 2023

Jorricks Oct 31, 2023

basilevs Nov 3, 2023

Jorricks Oct 31, 2023

basilevs Nov 3, 2023

Jorricks Oct 31, 2023

basilevs Nov 3, 2023

Jorricks Oct 31, 2023

basilevs Nov 3, 2023

Jorricks Oct 31, 2023

basilevs Nov 3, 2023

basilevs commented Nov 3, 2023 •

edited

Loading

Jorricks left a comment

	def cancel_notification(uid:str):
	def cancel_notification(uid: str) -> None:

	def __init__(self, uid):
	def __init__(self, uid: str) -> None:

	from .notification_sender import cancel_notification
	from mac_notifications import notification_sender

	cancel_notification(self.uid)
	notification_sender.cancel_notification(self.uid)

#14 Implement notification cancellation #15

#14 Implement notification cancellation #15

Conversation

basilevs commented Oct 13, 2023 • edited Loading

Jorricks commented Oct 31, 2023

basilevs commented Nov 1, 2023

Jorricks left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

basilevs commented Nov 3, 2023 • edited Loading

Jorricks left a comment

Choose a reason for hiding this comment

basilevs commented Oct 13, 2023 •

edited

Loading

basilevs commented Nov 3, 2023 •

edited

Loading