Support many speakers and improve overall runtime #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… new ones in each iteration + disable parallel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier this year I used your code to create LibriMix datasets for 5, 10, 15 and 20 speakers.
In the process I found out that running the scripts for many speakers (10 or more) is very slow or even stuck indefinitely. While debugging I found a bug that caused this and made a few other runtime improvements.
The details are listed in the README file and in the code.
I understand that there are a few modifications that need to be made before this PR can be accepted, and I will do so after I get a positive response from a maintainer.
Cheers