Merge Params with Body in API POST requests #278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
API resources for module control and notifications allow for POST requests, but ignore the body of the request, so they don't actually work. This merges the body and params objects to allow POST requests to work properly for these two endpoints.
Steps to reproduce
Attempt to call a POST request with only body contents containng the
moduleName
andaction
to/api/module
and you will get the default reponse of listing all modules' info. After the change, it will correctly call the action.Additional info
Note this is required to allow creation of Home Assistant REST Switches to work properly for showing/hiding modules. These require the URL to be the same and only the body to change. Currently this doesn't work because you have to use GET requests to different urls.