Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sku and mpn to product schema #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpotocic
Copy link

Fixes two search console warnings:
Missing field "sku"
No global identifier provided (e.g., gtin, mpn, isbn)

@JoppeDC
Copy link
Owner

JoppeDC commented Jun 17, 2020

Hi @dpotocic . Thanks for your PR. Adding the SKU, i can approve. But the MPN is not the same as the SKU, and Sylius has no field provided for this. We can either add a field for this, or remove it from the json.
Please note that these warnings should have no impact on the result of the snippet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants