This repository has been archived by the owner on Feb 21, 2024. It is now read-only.
Add (basic) custom chain support (e.g. Görli) #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add (limited) support for custom chains * Add `ethereumjs-common` dependency (also a dependency of `ethereumjs-tx`) * Define `getChainDefinition` helper * Implement custom chains in `ethereumjs-tx` transactions and update tests
rdig
approved these changes
Jul 21, 2019
There was a problem hiding this comment.
This is good to go.
A minor tidbit, that getChainDefinition should have used the core defaults constants, but in the interest of time, I'm going to publish it as-is. We can deal with those at a later date.
Also, I feel like this is pretty significant change internally (even though it's technically more of a fix), so I'm going to push this as a MINOR release.
| * @TODO Provide a means to specify all chain properties for transactions | ||
| */ | ||
| case 1: | ||
| case 1337: |
There was a problem hiding this comment.
These case values should have been taken from the core defaults:
| * using the current default for this property. This is also an | ||
| * assumption, and this should be made configurable. | ||
| */ | ||
| 'petersburg', |
There was a problem hiding this comment.
As above, this should have been added to the core defaults
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for custom chains (i.e. anything but the default for
ethereumjs-tx, which ismainnet). This is done by using theethereumjs-commonpackage to define a chain definition based on a default: eithermainnetfor chain IDs1(mainnet) and1337(local/private), or5forgoerli. Other chain IDs are sent as-is, which may cause validation errors if they are not supported byethereumjs-common.Ideally, all chain definition should all be configurable when signing a transaction, but that would require a fairly significant API change.
Additions
ethereumjs-commondependency (also a dependency ofethereumjs-tx)getChainDefinitionhelper inpurser-coreChanges
ethereumjs-txtransactions and update tests, forpurser-metamask,purser-ledgerandpurser-trezor.