Skip to content
This repository has been archived by the owner on Feb 21, 2024. It is now read-only.

Fix ethereumjs-tx import #253

Merged
merged 2 commits into from
Jul 16, 2019
Merged

Fix ethereumjs-tx import #253

merged 2 commits into from
Jul 16, 2019

Conversation

JamesLefrere
Copy link
Contributor

This PR makes a fix to the importing of ethereumjs-tx, which had a recent breaking change to its export.

Changes

  • Fix the ethereumjs-tx import that was a breaking change of its 2.x release
  • Side fix: Remove a (seemingly harmless) typo in the build script

* Remove a (harmless, but odd) typo in the build script
@JamesLefrere JamesLefrere requested a review from rdig July 16, 2019 14:44
@JamesLefrere JamesLefrere self-assigned this Jul 16, 2019
@JamesLefrere JamesLefrere force-pushed the fix/ethereumjs-tx-export branch from 9070133 to c624d03 Compare July 16, 2019 16:23
* Fix the `ethereumjs-tx` import that was a breaking change of its `2.x` release
* Update `ethereumjs-tx` mock
@JamesLefrere JamesLefrere force-pushed the fix/ethereumjs-tx-export branch from c624d03 to 8dec4f6 Compare July 16, 2019 16:25
Copy link
Member

@rdig rdig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @JamesLefrere! 💯 🥇 🌮 🌮

@@ -62,7 +62,7 @@ const buildIndividualModule = async (moduleName) => {
)}${chalk.white(' @ ')}${chalk.white.bold(
packageFile.version
)}`,
);cjsBuildFolder
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮 bonus!

@@ -1,6 +1,6 @@
/* @flow */

import EthereumTx from 'ethereumjs-tx';
import { Transaction as EthereumTx } from 'ethereumjs-tx';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a nice easy fix!

@rdig rdig added this to the Sprint 30 milestone Jul 16, 2019
@rdig rdig merged commit eaf2a01 into master Jul 16, 2019
@rdig rdig deleted the fix/ethereumjs-tx-export branch July 16, 2019 17:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants