Merge pull request #246 from JoinColony/hotfix/metamask-throw-on-cancel

purser-metamask will throw when cancelling signing a message or transaction
JoinColony · Jul 15, 2019 · 57eee3d · 57eee3d
2 parents 92683cd + ffb07ab
commit 57eee3d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 11 deletions.
diff --git a/modules/node_modules/@colony/purser-metamask/staticMethods.js b/modules/node_modules/@colony/purser-metamask/staticMethods.js
diff --git a/modules/tests/purser-metamask/staticMethods/signMessage.test.js b/modules/tests/purser-metamask/staticMethods/signMessage.test.js
@@ -184,8 +184,7 @@ describe('`Metamask` Wallet Module Static Methods', () => {
             mockedMessageSignature,
           ),
       );
-      expect(() => signMessage(mockedArgumentsObject)).not.toThrow();
-      expect(warning).toHaveBeenCalled();
+      expect(signMessage(mockedArgumentsObject)).rejects.toThrow();
     });
   });
 });
diff --git a/modules/tests/purser-metamask/staticMethods/signTransaction.test.js b/modules/tests/purser-metamask/staticMethods/signTransaction.test.js
@@ -211,7 +211,7 @@ describe('`Metamask` Wallet Module Static Methods', () => {
       });
       expect(signTransaction(mockedArgumentsObject)).rejects.toThrow();
     });
-    test('Warns if the user cancelled signing the message', async () => {
+    test('Throws if the user cancelled signing the message', async () => {
       /*
        * Mock it locally to simulate an error
        */
@@ -225,8 +225,7 @@ describe('`Metamask` Wallet Module Static Methods', () => {
             mockedTransactionHash,
           ),
       );
-      expect(() => signTransaction(mockedArgumentsObject)).not.toThrow();
-      expect(warning).toHaveBeenCalled();
+      expect(signTransaction(mockedArgumentsObject)).rejects.toThrow();
     });
   });
 });