Make lowercasing by Normalizer optional #84
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've noted that Normalizer lowercases all tokens that are fed into it. I added
lowercase
parameter that, when set tofalse
, doesn't lowercase tokens. By default it'strue
so it behaves like previous version.Motivation and Context
It seems it could be advantageous to not lowercase some inputs (for example if someone wanted to feed output of SparkNLP pipeline to some other algorithms that are case-sensitive).
How Has This Been Tested?
I've checked old tests for Normalizer and they still work, and I added tests for
lowercase = true
.Types of changes
Checklist: