Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite entity extractor #64

Merged
merged 4 commits into from
Dec 18, 2017
Merged

Rewrite entity extractor #64

merged 4 commits into from
Dec 18, 2017

Conversation

aleksei-ai
Copy link
Contributor

New Entity Extractor

Description

  1. Created Search Trie
  2. Rewrite Entity Extractor logic

Motivation and Context

Code was totally incorrect

#57

How Has This Been Tested?

  • SearchTrieSpec
  • EntityExtractorSpec
  • entities-extractor.ipynb

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

aleksei-ai and others added 4 commits December 14, 2017 19:19
- Removed built-in normalization and stemming from annotate, let to user decide
- Removed built-in stemming to input data. Could be improved with settings
- Fixed unit testing accordingly
- Tested python
- Cleaned notebook output
@saif-ellafi saif-ellafi merged commit 5e4dc62 into master Dec 18, 2017
@aleksei-ai aleksei-ai deleted the rewrite_entity_extractor branch December 18, 2017 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants