Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Regex NER #63

Merged
merged 1 commit into from
Dec 16, 2017
Merged

Remove Regex NER #63

merged 1 commit into from
Dec 16, 2017

Conversation

aleksei-ai
Copy link
Contributor

Regex NER deletion

Description

Regex based NER works bad. Crf based NER should be used instead

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [v] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [v] I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • [v] All new and existing tests passed.

@aleksei-ai aleksei-ai mentioned this pull request Dec 14, 2017
Closed
@saif-ellafi saif-ellafi merged commit 91d8acb into master Dec 16, 2017
@aleksei-ai aleksei-ai deleted the remove_regex_ner branch December 18, 2017 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saif-ellafi saif-ellafi saif-ellafi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksei-ai @saif-ellafi