Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARKNLP-1058] Adding aggressiveMatching parameter #14365

Merged
merged 1 commit into from
Aug 28, 2024
Merged

[SPARKNLP-1058] Adding aggressiveMatching parameter #14365

merged 1 commit into from
Aug 28, 2024

Conversation

danilojsl
Copy link
Contributor

@danilojsl danilojsl commented Aug 12, 2024 •
edited
Loading

Description

Adding aggressiveMatching parameter to find dates even in ambiguous or less common formats. This will instruct the annotator to execute runDateExtractorChain method for empty outputs

Motivation and Context

See issue #14100

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danilojsl danilojsl added DON'T MERGE Do not merge this PR bug-fix labels Aug 12, 2024
@maziyarpanahi maziyarpanahi changed the base branch from master to release/542-release-candidate August 28, 2024 09:53
@maziyarpanahi maziyarpanahi merged commit b785fa3 into release/542-release-candidate Aug 28, 2024
6 checks passed
@maziyarpanahi maziyarpanahi mentioned this pull request Aug 28, 2024
Merged
maziyarpanahi added a commit that referenced this pull request Aug 28, 2024
@maziyarpanahi @AbdullahMubeenAnwar
@danilojsl @actions-user
release/542-release-candidate (#14381)
6b7eb4b 
* Adding demo notebook for Image Classification Annotators (#14360)

* Upload SwinForImageClassification.ipynb

* Uploading ConvNextForImageClassification

* [SPARKNLP-1058] Adding aggressiveMatching parameter (#14365)

* [SPARKNLP-1059] Adding aggressiveMatching parameter to DocumentSimilarityRanker (#14370)

* [SPARKNLP-1059] Adding aggressiveMatching parameter to DocumentSimilarityRanker

* [SPARKNLP-1059] Updates Document Similarity Ranker notebook

* Bump to 5.4.2 [run doc]

* Update Scala and Python APIs

* update conda to 5.4.2 [skip test]

---------

Co-authored-by: Abdullah mubeen <77073730+AbdullahMubeenAnwar@users.noreply.github.com>
Co-authored-by: Danilo Burbano <37355249+danilojsl@users.noreply.github.com>
Co-authored-by: github-actions <action@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maziyarpanahi maziyarpanahi maziyarpanahi approved these changes

Assignees
No one assigned
Labels
bug-fix DON'T MERGE Do not merge this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danilojsl @maziyarpanahi