Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Mxbai Embeddings #14355

Conversation

ahmedlone127
Copy link
Contributor

This PR introduces the Mxbai Embedding family of models

@maziyarpanahi maziyarpanahi changed the base branch from master to release/550-release-candidate September 1, 2024 18:18
@maziyarpanahi maziyarpanahi merged commit 707bb16 into release/550-release-candidate Sep 1, 2024
4 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10656334014

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 27 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.02%) to 62.392%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/scala/com/johnsnowlabs/nlp/pretrained/ResourceDownloader.scala 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/scala/com/johnsnowlabs/storage/HasStorageModel.scala 1 75.0%
src/main/scala/com/johnsnowlabs/nlp/util/io/ResourceHelper.scala 1 47.65%
src/main/scala/com/johnsnowlabs/nlp/pretrained/S3ResourceDownloader.scala 1 52.59%
src/main/scala/com/johnsnowlabs/nlp/util/io/OutputHelper.scala 1 56.41%
src/main/scala/com/johnsnowlabs/util/ZipArchiveUtil.scala 2 85.33%
src/main/scala/com/johnsnowlabs/util/FileHelper.scala 2 32.0%
src/main/scala/com/johnsnowlabs/nlp/pretrained/ResourceDownloader.scala 19 40.98%
Totals Coverage Status
Change from base Build 10656318182: -0.02%
Covered Lines: 8967
Relevant Lines: 14372

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants