Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixies #14307

Merged
merged 1 commit into from
May 27, 2024
Merged

Fixies #14307

merged 1 commit into from
May 27, 2024

Conversation

agsfer
Copy link
Contributor

@agsfer agsfer commented May 27, 2024 •
edited
Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@agsfer agsfer requested a review from maziyarpanahi May 27, 2024 14:04
@maziyarpanahi maziyarpanahi merged commit 6616323 into master May 27, 2024
1 check passed
maziyarpanahi added a commit that referenced this pull request Jun 12, 2024
@ahmedlone127 @DevinTDHa
@agsfer @maziyarpanahi
Add Pooling Average to Broken XXXForSentenceEmbedding annotators (#14328
1cba7e3 
)

* SPARKNLP-1036: Onnx Example notebooks (#14234)

* SPARKNLP-1036: Fix dev python kernel names

* SPARKNLP-1036: Bump transformers version

* SPARKNLP-1036: Fix Colab buttons

* SPARKNLP-1036: Pin onnx version for compatibility

* SPARKNLP-1036: Upgrade Spark version

* SPARKNLP-1036: Minor Fixes

* SPARKNLP-1036: Clean Metadata

* SPARKNLP-1036: Add/Adjust Documentation

- Note for supported Spark Version of Annotators
- added missing Documentation for BGEEmbeddings

* Fixies (#14307)

* adding fix for broken annotators

---------

Co-authored-by: Devin Ha <33089471+DevinTDHa@users.noreply.github.com>
Co-authored-by: Lev <agsfer@gmail.com>
Co-authored-by: Maziyar Panahi <maziyar.panahi@iscpif.fr>
maziyarpanahi pushed a commit that referenced this pull request Jun 21, 2024
@dcecchini @DevinTDHa @agsfer
Fix models link on FAQ (#14333)
4356794 
* SPARKNLP-1036: Onnx Example notebooks (#14234)

* SPARKNLP-1036: Fix dev python kernel names

* SPARKNLP-1036: Bump transformers version

* SPARKNLP-1036: Fix Colab buttons

* SPARKNLP-1036: Pin onnx version for compatibility

* SPARKNLP-1036: Upgrade Spark version

* SPARKNLP-1036: Minor Fixes

* SPARKNLP-1036: Clean Metadata

* SPARKNLP-1036: Add/Adjust Documentation

- Note for supported Spark Version of Annotators
- added missing Documentation for BGEEmbeddings

* Fixies (#14307)

* Fix models link

---------

Co-authored-by: Devin Ha <33089471+DevinTDHa@users.noreply.github.com>
Co-authored-by: Lev <agsfer@gmail.com>
maziyarpanahi added a commit that referenced this pull request Jun 21, 2024
@AbdullahMubeenAnwar @DevinTDHa
@agsfer @maziyarpanahi
uploading UAEEmbeddings notebook (#14324)
ac9de09 
* SPARKNLP-1036: Onnx Example notebooks (#14234)

* SPARKNLP-1036: Fix dev python kernel names

* SPARKNLP-1036: Bump transformers version

* SPARKNLP-1036: Fix Colab buttons

* SPARKNLP-1036: Pin onnx version for compatibility

* SPARKNLP-1036: Upgrade Spark version

* SPARKNLP-1036: Minor Fixes

* SPARKNLP-1036: Clean Metadata

* SPARKNLP-1036: Add/Adjust Documentation

- Note for supported Spark Version of Annotators
- added missing Documentation for BGEEmbeddings

* Fixies (#14307)

* uploading UAEEmbeddings notebook

Adding UAEEmbeddings example notebook

---------

Co-authored-by: Devin Ha <33089471+DevinTDHa@users.noreply.github.com>
Co-authored-by: Lev <agsfer@gmail.com>
Co-authored-by: Maziyar Panahi <maziyar.panahi@iscpif.fr>
maziyarpanahi added a commit that referenced this pull request Jun 28, 2024
@mehmetbutgul @DevinTDHa
@agsfer @maziyarpanahi
Refactor OpenAIEmbeddings (#14334)
09dc500 
* SPARKNLP-1036: Onnx Example notebooks (#14234)

* SPARKNLP-1036: Fix dev python kernel names

* SPARKNLP-1036: Bump transformers version

* SPARKNLP-1036: Fix Colab buttons

* SPARKNLP-1036: Pin onnx version for compatibility

* SPARKNLP-1036: Upgrade Spark version

* SPARKNLP-1036: Minor Fixes

* SPARKNLP-1036: Clean Metadata

* SPARKNLP-1036: Add/Adjust Documentation

- Note for supported Spark Version of Annotators
- added missing Documentation for BGEEmbeddings

* Fixies (#14307)

* refactor OpenAIEmbeddings in Scala

* refactor OpenAIEmbeddings in Python

* add pytest.mark.slow and improve doc

---------

Co-authored-by: Devin Ha <33089471+DevinTDHa@users.noreply.github.com>
Co-authored-by: Lev <agsfer@gmail.com>
Co-authored-by: Maziyar Panahi <maziyar.panahi@iscpif.fr>
@agsfer agsfer deleted the little-fixies branch July 30, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maziyarpanahi maziyarpanahi maziyarpanahi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agsfer @maziyarpanahi