Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bert for zero shot classification crashes on sentence basis #14276

Conversation

ahmedlone127
Copy link
Contributor

@ahmedlone127 ahmedlone127 commented May 24, 2024

Description

This change modifies BertForZeroShotClassification by adding a method for padding with zeros all required arrays inside a batch to ensure all of them have the same length.

How Has This Been Tested?

ran local unit tests that were previously failing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ahmedlone127 ahmedlone127 changed the title adding padded tokens bert for zero shot classification crashes on sentence basis May 24, 2024
@maziyarpanahi maziyarpanahi changed the base branch from master to release/540-release-candidate May 24, 2024 08:18
@maziyarpanahi maziyarpanahi merged commit d083420 into release/540-release-candidate May 24, 2024
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants