Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BGE Embeddings #14090

Merged
merged 2 commits into from
Dec 27, 2023
Merged

Conversation

dcecchini
Copy link
Contributor

@dcecchini dcecchini commented Dec 12, 2023

Description

Created Scala and Python classes for the BGE Embeddings models.

Motivation and Context

Spark NLP currently supports BGE embeddings but didn't have a specific class to store and work with those models. The current approach is to load the models as BertEmbeddings, which loads the sentence embeddings model, BGE, as word embeddings. To load the model as sentence embeddings, I added a new class based on the current E5 embeddings annotator.

How Has This Been Tested?

The code has not been tested, as I don't have a Scala environment set yet.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dcecchini dcecchini requested a review from danilojsl December 16, 2023 11:49
@maziyarpanahi maziyarpanahi changed the base branch from master to release/521-release-candidate December 27, 2023 15:37
@maziyarpanahi maziyarpanahi merged commit 05dda07 into release/521-release-candidate Dec 27, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants