-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing onnx saving path bug #13959
Fixing onnx saving path bug #13959
Conversation
@maziyarpanahi @ahmedlone127 I pushed a fix, which addresses the underlying issue. The reason why it used to work for TF but not for onnx is the following: In tf we always had a name for the graph already defined (
|
…date * [SPARKNLP-906] Fix reading suffix (#13945) * Sparknlp 888 Add ONNX support to MPNet embeddings (#13955) * adding onxx support to mpnet * remove name in test * updating default name for mpnet models in scala and python * updating default model name * Adding ONNX Support to ALBERT Token and Sequence Classification and Question Answering annotators (#13956) * SPARKNLP-891 Adding ONNX support for AlbertQuestionAnswering SPARKNLP-892 Adding ONNX support for AlbertSequenceClassification SPARKNLP-893 Adding ONNX support for AlbertTokenClassification * SPARKNLP-891 Adding ONNX support for AlbertQuestionAnswering SPARKNLP-892 Adding ONNX support for AlbertSequenceClassification SPARKNLP-893 Adding ONNX support for AlbertTokenClassification * SPARKNLP-884 Enabling getVectors method to get word vectors as spark dataframe (#13957) * [SPARKNLP-890] ONNX E5 MPnet example (#13958) * Bump version to 5.1.1 * [SPARKNLP-891] [SPARKNLP-892] [SPARKNLP-893] Adding docs for ONNX support in AlbertXXX * Fix misspelling [skip test] * Fixing onnx saving path bug (#13959) * fixing onnx write issue on windows * fixing indentation * fixing formatting * fixing formatting * final formatting fix * Fix onnx saving bug --------- Co-authored-by: Devin Ha <t.ha@tu-berlin.de> Co-authored-by: Maziyar Panahi <maziyar.panahi@iscpif.fr> --------- Co-authored-by: Devin Ha <33089471+DevinTDHa@users.noreply.github.com> Co-authored-by: ahmedlone127 <ahmedlone127@gmail.com> Co-authored-by: Danilo Burbano <37355249+danilojsl@users.noreply.github.com> Co-authored-by: Danilo Burbano <danilo@johnsnowlabs.com> Co-authored-by: Devin Ha <t.ha@tu-berlin.de>
FIxes saving of Onnx models on windows
Description
Currently, Onnx models can't be saved on windows because of the temporary path being used. This PR fixes the temporary path by replacing the character which can raise an exception while saving
How Has This Been Tested?
Tested locally by saving models and reloading them on windows
Screenshots (if appropriate):
Types of changes
Checklist: