Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ADT for ModelEngine #13862

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

wolliq
Copy link
Contributor

@wolliq wolliq commented Jun 22, 2023

Description

Created ADT for ModelEngine to prepare future extensions with clean typing

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@wolliq wolliq requested a review from maziyarpanahi June 22, 2023 07:15
@maziyarpanahi maziyarpanahi merged commit ffdc375 into feature/onnx-runtime Jun 23, 2023
@maziyarpanahi maziyarpanahi self-assigned this Jun 23, 2023
maziyarpanahi added a commit that referenced this pull request Jul 1, 2023
* Add ONNX Runtime to the dependencies

* Add both CPU and GPU coordinates for onnxruntime

* Implement OnnxSerializeModel

* Implement OnnxWrapper

* Update error message for loading external models

* Add support for ONNX to BertEmbeddings annotator

* Add support for ONNX to BERT backend

* Add support for ONNX to DeBERTa

* Implement ONNX in DeBERTa backend

* Adapt Bert For sentence embeddings with the new backend

* Update unit test for BERT (temp)

* Update unit test for DeBERTa (temp)

* Update onnxruntime and google cloud dependencies

* Seems Apple Silicon and Aarch64 are supported in onnxruntime

* Cleaning up

* Remove bad merge

* Update BERT unit test

* Add fix me to the try

* Making withSafeOnnxModelLoader thread safe

* update onnxruntime

* Revert back to normal unit tests for now [ski ptest]

* Added ADT for ModelEngine (#13862)

Co-authored-by: Stefano Lori <s.lori@izicap.com>

* Optimize ONNX on CPU

* refactor

* Add ONNX support to DistilBERT

* Add support for ONNX in RoBERTa

* Fix the bad serialization on write

* Fix using the wrong object

---------

Co-authored-by: Stefano Lori <wolliq@users.noreply.github.com>
Co-authored-by: Stefano Lori <s.lori@izicap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants