Add unzip param to downloadModelDirectly in ResourceDownloader #13796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a unzip argument to downloadModelDirectly in ResourceDownloader
Description
issue: https://github.com/JohnSnowLabs/spark-nlp-internal/issues/1837
Added unzip argument to downloadModelDirectly() in ResourceDownloader.
BEFORE: downloadModelDirectly(name, remote_loc="public/models")
AFTER: downloadModelDirectly(name, remote_loc="public/models", unzip=True)
Updated also name argument
BEFORE: clinical/models/deidentify_enriched_clinical_en_2.7.2_2.4_1611917177874.zip
AFTER: 1--> clinical/models/deidentify_enriched_clinical_en_2.7.2_2.4_1611917177874.zip
2--> s3://auxdata.johnsnowlabs.com/clinical/models/deidentify_enriched_clinical_en_2.7.2_2.4_1611917177874.zip
deleted duplicate codes
Note: supported Backward compatibility
How Has This Been Tested?
Tested via Scala and Python tests locally
Screenshots (if appropriate):
Types of changes
Checklist: