SPARKNLP-797: Introduce Protected Features #13777
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the functionality of
Feature
class parameters to be protected. This means, that theFeature
can only be set once during the initialization process (for exampleloadSavedModel
). Subsequent attempts to set it will result in an exception. The reason is, that some parameters of pretrained models should not be set after they have been loaded.The following
Feature
parameters have been set to be protected:vocabulary
merges
signatures
labels
Motivation and Context
Not letting the user set these parameters will result in less unintended behavior.
How Has This Been Tested?
Added new tests to verify the new behavior.
Screenshots (if appropriate):
Types of changes
Checklist: