Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPARKNLP-819 Adding changes to make spark-nlp 3.4.0 default version #13773

Merged
merged 2 commits into from
May 10, 2023
Merged

SPARKNLP-819 Adding changes to make spark-nlp 3.4.0 default version #13773

merged 2 commits into from
May 10, 2023

Conversation

danilojsl
Copy link
Contributor

Description

Adding changes to make spark-nlp 3.4.0 default version by updating some imports

Motivation and Context

Use the latest spark version

How Has This Been Tested?

Screenshots (if appropriate):

  • Local Tests
  • Google Colab notebooks
  • Databricks 13

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danilojsl danilojsl added the DON'T MERGE Do not merge this PR label Apr 27, 2023
@danilojsl danilojsl requested a review from maziyarpanahi April 27, 2023 13:42
@maziyarpanahi
Add unit test for sark 3.4
5255538 
- fix GA job without spark version
- fix sark34 references in build.sbt
@maziyarpanahi maziyarpanahi added the new-feature Introducing a new feature label Apr 27, 2023
@maziyarpanahi maziyarpanahi changed the base branch from master to release/442-release-candidate May 10, 2023 09:18
@maziyarpanahi maziyarpanahi self-assigned this May 10, 2023
@maziyarpanahi maziyarpanahi merged commit 706ea4a into release/442-release-candidate May 10, 2023
@maziyarpanahi maziyarpanahi mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maziyarpanahi maziyarpanahi maziyarpanahi approved these changes

Assignees

@maziyarpanahi maziyarpanahi

Labels
DON'T MERGE Do not merge this PR new-feature Introducing a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danilojsl @maziyarpanahi