Fix Tapas bug due to exceeding the maximum rank value #13772
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bug fix for the Tapas model.
Description
The problem is that the maximum value rank in Tapas is limited to 255 and if the text is long enough you may end up with higher ranks. The solution is to replace ranks higher than 255 with 255.
Motivation and Context
The issue was reported by a user in the slack channel. If you feed a long text (i.e table) you may end up with ranks higher than 255 and this is the max value allowed by the model (perhaps they used a byte variable to represent it or a static array). Such ranks case a Tensorflow exception.
How Has This Been Tested?
I first reproduced the problem by running Tapas on long enough texts and made sure that the fixes solves the problem
Screenshots (if appropriate):
Types of changes
Checklist: