Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPARKNLP-750 DependencyParserModel Outputs All Chunks as <no-type> #13620

Merged
merged 1 commit into from
Mar 14, 2023
Merged

SPARKNLP-750 DependencyParserModel Outputs All Chunks as <no-type> #13620

merged 1 commit into from
Mar 14, 2023

Conversation

danilojsl
Copy link
Contributor

@danilojsl danilojsl commented Mar 8, 2023 •
edited
Loading

Description

This change fixes a bug that outputs all tokens as <no-type> for some sentences

Motivation and Context

Check issue #2775

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danilojsl danilojsl changed the title SPARKNLP-750 DependencyParserModel Outputs All <no-type> SPARKNLP-750 DependencyParserModel Outputs All Chunks as <no-type> Mar 8, 2023
@maziyarpanahi maziyarpanahi self-assigned this Mar 10, 2023
@danilojsl danilojsl requested a review from maziyarpanahi March 10, 2023 20:47
@maziyarpanahi maziyarpanahi changed the base branch from master to release/432-release-candidate March 14, 2023 08:53
@maziyarpanahi maziyarpanahi merged commit 85ef6ae into release/432-release-candidate Mar 14, 2023
@maziyarpanahi maziyarpanahi mentioned this pull request Mar 14, 2023
Merged
maziyarpanahi pushed a commit that referenced this pull request May 10, 2023
@danilojsl
SPARKNLP-750 Handling all scores as -Infinity and refactoring depende…
166bcbc 
…ncy parser (#13620)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maziyarpanahi maziyarpanahi maziyarpanahi approved these changes

Assignees

@maziyarpanahi maziyarpanahi

Labels
bug-fix DON'T MERGE Do not merge this PR enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danilojsl @maziyarpanahi