Sparknlp 747 Date2Chunk and Chunk2Doc are not in the correct Python module #13609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- They are in annotators on the Scala side - They never worked if they are part of PipelineModel when they were being loaded
maziyarpanahi
added a commit
that referenced
this pull request
May 10, 2023
…odule (#13609) * Move Chunk2Doc and Date2Chunk from base to annotators - They are in annotators on the Scala side - They never worked if they are part of PipelineModel when they were being loaded * Refactor Chunk2Doc from base to annotator * Update unit tests * Fix referencing wrong package in the unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a pipeline is saved with either Date2Chunk or Chunk2Doc annotators, when it is being loaded in Python it cannot find these annotators. The pacakges were not sync between Python and Scala.
These two annotators are now under
annotatorspackage in Python and Scala