Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPARKNLP-88 Adding support for S3 in CoNLL, POS, CoNLLU #13596

Merged
merged 3 commits into from
Mar 14, 2023
Merged

SPARKNLP-88 Adding support for S3 in CoNLL, POS, CoNLLU #13596

merged 3 commits into from
Mar 14, 2023

Conversation

danilojsl
Copy link
Contributor

Description

This change adds S3 support for CoNLL, POS, CoNLLU components.

Motivation and Context

Keep consistency between helper components used to files for training

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danilojsl danilojsl requested review from DevinTDHa and maziyarpanahi and removed request for DevinTDHa March 2, 2023 21:44
@danilojsl danilojsl added enhancement DON'T MERGE Do not merge this PR labels Mar 2, 2023
@maziyarpanahi maziyarpanahi added the new-feature Introducing a new feature label Mar 5, 2023
@maziyarpanahi
Copy link
Member

Thanks @danilojsl

We do have this error from the Python unit tests:

E                   : java.io.FileNotFoundException: file or folder: file:////Users/runner/work/spark-nlp/spark-nlp/python/../src/test/resources/entity-extractor/test-chunks.txt not found
[175](https://github.com/JohnSnowLabs/spark-nlp/actions/runs/4318508860/jobs/7552459556#step:8:176)

Might be the relative path to that asset

@danilojsl danilojsl force-pushed the feature/SPARKNLP-88-S3-path-support-for-CoNLL-POS-CoNLLU-etc branch from 8280ec8 to 6e273bf Compare March 8, 2023 19:54
@danilojsl
Copy link
Contributor Author

Thanks @danilojsl

We do have this error from the Python unit tests:

E                   : java.io.FileNotFoundException: file or folder: file:////Users/runner/work/spark-nlp/spark-nlp/python/../src/test/resources/entity-extractor/test-chunks.txt not found
[175](https://github.com/JohnSnowLabs/spark-nlp/actions/runs/4318508860/jobs/7552459556#step:8:176)

Might be the relative path to that asset

Hi @maziyarpanahi, I replicated the error and will take a look at it

@maziyarpanahi maziyarpanahi changed the base branch from master to release/432-release-candidate March 14, 2023 08:48
@maziyarpanahi maziyarpanahi merged commit e87a01b into release/432-release-candidate Mar 14, 2023
@maziyarpanahi maziyarpanahi mentioned this pull request Mar 14, 2023
Merged
maziyarpanahi pushed a commit that referenced this pull request May 10, 2023
@danilojsl
SPARKNLP-88 Adding support for S3 in CoNLL, POS, CoNLLU (#13596)
cedca68 
* SPARKNLP-88 Adding support for S3 in CoNLL, POS, CoNLLU

* SPARKNLP-88 Fix parsePath issue with file://

* SPARKNLP-88 Adds doesPathExists to handle file prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maziyarpanahi maziyarpanahi maziyarpanahi approved these changes

Assignees
No one assigned
Labels
DON'T MERGE Do not merge this PR enhancement new-feature Introducing a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danilojsl @maziyarpanahi