Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPARKNLP-743: Add parameter to SparkNLP.start #13510

Conversation

DevinTDHa
Copy link
Member

  • Added params parameter which can supply custom configurations to the SparkSession

Description

This PR adds additional parameters that are available in the python version but not in the Scala version.

  • added the params parameter, that enables users to add extra spark configurations easily
  • python parameters real_time_output and output_level do not apply, as they forward the output of the JVMs to the python program

How Has This Been Tested?

Added a new test (ignore for CI) for SparkNLP start

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

- Added params parameter which can supply custom
  configurations to the SparkSession
@DevinTDHa DevinTDHa added new-feature Introducing a new feature DON'T MERGE Do not merge this PR labels Feb 13, 2023
@maziyarpanahi maziyarpanahi changed the base branch from master to release/431-release-candidate February 24, 2023 10:53
@maziyarpanahi maziyarpanahi merged commit 98c8ffa into JohnSnowLabs:release/431-release-candidate Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DON'T MERGE Do not merge this PR new-feature Introducing a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants