SPARKNLP-728 Avoid Copying Existing Models on S3/GCP #13423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen cache_pretrained is defined as S3 bucket
…when cache_pretrained is defined as GCP bucket
maziyarpanahi
previously approved these changes
Jan 28, 2023
josejuanmartinez
pushed a commit
that referenced
this pull request
Feb 17, 2023
* SPARKNLP-728 Verifies if model already exist in S3 before unzipping when cache_pretrained is defined as S3 bucket * SPARKNLP-728 Verifies if model already exist in GCP before unzipping when cache_pretrained is defined as GCP bucket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change introduces an enhancement when loading models from S3 or GCP. Which consists in checking if a model already exists in a bucket before copying from models hub to an external bucket.
Motivation and Context
The current implementation always copies models from models hub when
cache_pretainedis configure for S3 or GCP. This behavior is inefficient and makes an unnecessary usage of bandwidth and network resources.How Has This Been Tested?
Screenshots (if appropriate):
Google Colab Notebooks
Types of changes
Checklist: