Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fin/leg clf models' benchmark #13276

Merged
merged 17 commits into from
Jan 2, 2023
Merged

Update fin/leg clf models' benchmark #13276

merged 17 commits into from
Jan 2, 2023

Conversation

bunyamin-polat
Copy link
Contributor

@bunyamin-polat bunyamin-polat commented Dec 25, 2022 •
edited
Loading

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Damla-Gurbaz Damla-Gurbaz requested a review from Cabir40 December 28, 2022 20:31
@Cabir40 Cabir40 requested a review from Mary-Sci January 2, 2023 11:24
@vkocaman vkocaman merged commit 574ac4a into master Jan 2, 2023
danilojsl pushed a commit that referenced this pull request Jan 2, 2023
@bunyamin-polat @danilojsl
Update fin/leg clf models' benchmark (#13276)
5f71b64
maziyarpanahi pushed a commit that referenced this pull request Jan 6, 2023
@DevinTDHa @josejuanmartinez
@bunyamin-polat @rpranab @jdobes-cz @agsfer
Fix links for APIs in Open Source (#13312)
fef1760 
* Update 2022-09-27-finassertion_time_en.md

* Update 2022-08-17-finner_orgs_prods_alias_en_3_2.md

* Update 2022-08-17-legner_orgs_prods_alias_en_3_2.md

* Update fin/leg clf models' benchmark (#13276)

* relese note for 4.5.0 including gif (#13301)

Co-authored-by: pranab <pranab@johnsnowlabs.com>
Co-authored-by: diatrambitas <JSL.Git2018>

* Databricks installation instructions update. (#13261)

* Databricks installation instructions update.

* updated DB installation steps

Co-authored-by: diatrambitas <JSL.Git2018>

* Update 2022-09-27-legassertion_time_en.md

* Input output images (#13310)

* [skip test] Fix links for APIs in Open Source

Co-authored-by: Jose J. Martinez <36634572+josejuanmartinez@users.noreply.github.com>
Co-authored-by: Bünyamin Polat <78386903+bunyamin-polat@users.noreply.github.com>
Co-authored-by: rpranab <33893292+rpranab@users.noreply.github.com>
Co-authored-by: pranab <pranab@johnsnowlabs.com>
Co-authored-by: Jiri Dobes <44785730+jdobes-cz@users.noreply.github.com>
Co-authored-by: Lev <agsfer@gmail.com>
maziyarpanahi added a commit that referenced this pull request Jan 12, 2023
@maziyarpanahi @dcecchini
@danilojsl @DevinTDHa @josejuanmartinez @bunyamin-polat @rpranab @jdobes-cz @agsfer @actions-user
Spark NLP 427 release candidate (#13290)
95154a9 
* Removed duplicated method definition (#13280)

Removed the duplicated definition of method `setWeightedDistPath` from `ContextSpellCheckerApproach`.

* SPARKNLP-703 Fix Finisher outputAnnotatorType Issue (#13282)

* SPARKNLP-703 adding control to avoid loading outputAnnotatorType attribute when components don't override it

* SPARKNLP-703 Adding validation when PipelineModel is part of stages

* SPARKNLP-667: Fix indexing issue for custom pattern (#13283)

- fix for patterns with lookahead/behinds that have 0 width matches, indexes would not be calculated correctly
- resolved some warnings
- refactored tokenizer tests and added new index alignment check

* SPARKNLP-708 Enabling embeddings output in LightPipeline.fullAnnotate (#13284)

Co-authored-by: Maziyar Panahi <maziyar.panahi@iscpif.fr>

* Bump version to 4.2.7

* SPARKNLP-667: Added try-catch block for custom pattern/char (#13291)

- if a user provided pattern/char can not be applied, a
  message will be logged instead of throwing an exception

* Enable dropInvalid in reading photos

* disable `assemble an image input` unit test

- this unit test fails randomly for either a `javax.imageio.IIOException: Unsupported Image Type` or bad assert of `annotationImage.height`. Which suggests something is happening on the OS/file system level as if you re-try it will pass

* SPARKNLP-713 Modifies Default Values GraphExtraction (#13305)

* SPARKNLP-713 Modifies default values of explodeEntities and mergeEntities

* SPARKNLP-713 Refactor GraphFinisher Tests

* SPARKNLP-713 Adding warning message for empty paths

* Fix links for APIs in Open Source (#13312)

* Update 2022-09-27-finassertion_time_en.md

* Update 2022-08-17-finner_orgs_prods_alias_en_3_2.md

* Update 2022-08-17-legner_orgs_prods_alias_en_3_2.md

* Update fin/leg clf models' benchmark (#13276)

* relese note for 4.5.0 including gif (#13301)

Co-authored-by: pranab <pranab@johnsnowlabs.com>
Co-authored-by: diatrambitas <JSL.Git2018>

* Databricks installation instructions update. (#13261)

* Databricks installation instructions update.

* updated DB installation steps

Co-authored-by: diatrambitas <JSL.Git2018>

* Update 2022-09-27-legassertion_time_en.md

* Input output images (#13310)

* [skip test] Fix links for APIs in Open Source

Co-authored-by: Jose J. Martinez <36634572+josejuanmartinez@users.noreply.github.com>
Co-authored-by: Bünyamin Polat <78386903+bunyamin-polat@users.noreply.github.com>
Co-authored-by: rpranab <33893292+rpranab@users.noreply.github.com>
Co-authored-by: pranab <pranab@johnsnowlabs.com>
Co-authored-by: Jiri Dobes <44785730+jdobes-cz@users.noreply.github.com>
Co-authored-by: Lev <agsfer@gmail.com>

* SPARKNLP-715 Fix sentence index computation (#13318)

* Update CHANGELOG for 4.2.7 [run doc]

* Update Scala and Python APIs

* Release Spark NLP 4.2.7 on Conda [skip test]

Co-authored-by: David Cecchini <dadachini@hotmail.com>
Co-authored-by: Danilo Burbano <37355249+danilojsl@users.noreply.github.com>
Co-authored-by: Devin Ha <33089471+DevinTDHa@users.noreply.github.com>
Co-authored-by: Jose J. Martinez <36634572+josejuanmartinez@users.noreply.github.com>
Co-authored-by: Bünyamin Polat <78386903+bunyamin-polat@users.noreply.github.com>
Co-authored-by: rpranab <33893292+rpranab@users.noreply.github.com>
Co-authored-by: pranab <pranab@johnsnowlabs.com>
Co-authored-by: Jiri Dobes <44785730+jdobes-cz@users.noreply.github.com>
Co-authored-by: Lev <agsfer@gmail.com>
Co-authored-by: github-actions <action@github.com>
josejuanmartinez added a commit that referenced this pull request Feb 17, 2023
@DevinTDHa @josejuanmartinez
@bunyamin-polat @rpranab @jdobes-cz @agsfer
Fix links for APIs in Open Source (#13312)
69f4448 
* Update 2022-09-27-finassertion_time_en.md

* Update 2022-08-17-finner_orgs_prods_alias_en_3_2.md

* Update 2022-08-17-legner_orgs_prods_alias_en_3_2.md

* Update fin/leg clf models' benchmark (#13276)

* relese note for 4.5.0 including gif (#13301)

Co-authored-by: pranab <pranab@johnsnowlabs.com>
Co-authored-by: diatrambitas <JSL.Git2018>

* Databricks installation instructions update. (#13261)

* Databricks installation instructions update.

* updated DB installation steps

Co-authored-by: diatrambitas <JSL.Git2018>

* Update 2022-09-27-legassertion_time_en.md

* Input output images (#13310)

* [skip test] Fix links for APIs in Open Source

Co-authored-by: Jose J. Martinez <36634572+josejuanmartinez@users.noreply.github.com>
Co-authored-by: Bünyamin Polat <78386903+bunyamin-polat@users.noreply.github.com>
Co-authored-by: rpranab <33893292+rpranab@users.noreply.github.com>
Co-authored-by: pranab <pranab@johnsnowlabs.com>
Co-authored-by: Jiri Dobes <44785730+jdobes-cz@users.noreply.github.com>
Co-authored-by: Lev <agsfer@gmail.com>
josejuanmartinez added a commit that referenced this pull request Feb 17, 2023
@DevinTDHa @josejuanmartinez
@bunyamin-polat @rpranab @jdobes-cz @agsfer
Fix links for APIs in Open Source (#13312)
0e92b02 
* Update 2022-09-27-finassertion_time_en.md

* Update 2022-08-17-finner_orgs_prods_alias_en_3_2.md

* Update 2022-08-17-legner_orgs_prods_alias_en_3_2.md

* Update fin/leg clf models' benchmark (#13276)

* relese note for 4.5.0 including gif (#13301)

Co-authored-by: pranab <pranab@johnsnowlabs.com>
Co-authored-by: diatrambitas <JSL.Git2018>

* Databricks installation instructions update. (#13261)

* Databricks installation instructions update.

* updated DB installation steps

Co-authored-by: diatrambitas <JSL.Git2018>

* Update 2022-09-27-legassertion_time_en.md

* Input output images (#13310)

* [skip test] Fix links for APIs in Open Source

Co-authored-by: Jose J. Martinez <36634572+josejuanmartinez@users.noreply.github.com>
Co-authored-by: Bünyamin Polat <78386903+bunyamin-polat@users.noreply.github.com>
Co-authored-by: rpranab <33893292+rpranab@users.noreply.github.com>
Co-authored-by: pranab <pranab@johnsnowlabs.com>
Co-authored-by: Jiri Dobes <44785730+jdobes-cz@users.noreply.github.com>
Co-authored-by: Lev <agsfer@gmail.com>
@KshitizGIT KshitizGIT deleted the fin_leg_clf_update branch March 2, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cabir40 Cabir40 Cabir40 approved these changes

@Damla-Gurbaz Damla-Gurbaz Awaiting requested review from Damla-Gurbaz

@Mary-Sci Mary-Sci Awaiting requested review from Mary-Sci

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bunyamin-polat @Cabir40 @vkocaman @Mary-Sci @Damla-Gurbaz