Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding audio input support in LightPipeline #12895

Conversation

danilojsl
Copy link
Contributor

@danilojsl danilojsl commented Oct 5, 2022

Description

This change adds the required methods in Scala and Python to allow sending audio inputs as a collection of floats to fullAnnotate method in LightPipeline.

Motivation and Context

Currently Wav2Vec2ForCTC is the only available as a Spark transformer, users that rely on LightPipline for their processes cannot use this new annotator. By enabling this usage in LightPipeline users will be able to use it.

How Has This Been Tested?

Screenshots (if appropriate):

  • Unit tests
  • Local tests
  • Google Colab Notebook

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Code improvements with no or little impact
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING page.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@danilojsl danilojsl changed the base branch from master to release/421-release-candidate October 5, 2022 21:32
@danilojsl danilojsl added the new-feature Introducing a new feature label Oct 5, 2022
@maziyarpanahi maziyarpanahi added the DON'T MERGE Do not merge this PR label Oct 6, 2022
@maziyarpanahi maziyarpanahi self-assigned this Oct 6, 2022
@maziyarpanahi
Copy link
Member

@danilojsl Thanks for this feature. Something seems to be different in LightPipeline that resulted in this test failing:

maziyarpanahi and others added 3 commits October 6, 2022 14:15
… github.com:JohnSnowLabs/spark-nlp into SPARKNLP-602-enable-annotation-audio-light-pipeline
@danilojsl
Copy link
Contributor Author

@maziyarpanahi, yes I added the commit that solves that error

@maziyarpanahi maziyarpanahi merged commit b489393 into release/421-release-candidate Oct 11, 2022
@KshitizGIT KshitizGIT deleted the SPARKNLP-602-enable-annotation-audio-light-pipeline branch March 2, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix DON'T MERGE Do not merge this PR new-feature Introducing a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants