-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding audio input support in LightPipeline #12895
Merged
maziyarpanahi
merged 7 commits into
release/421-release-candidate
from
SPARKNLP-602-enable-annotation-audio-light-pipeline
Oct 11, 2022
Merged
Adding audio input support in LightPipeline #12895
maziyarpanahi
merged 7 commits into
release/421-release-candidate
from
SPARKNLP-602-enable-annotation-audio-light-pipeline
Oct 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilojsl
changed the base branch from
master
to
release/421-release-candidate
October 5, 2022 21:32
@danilojsl Thanks for this feature. Something seems to be different in LightPipeline that resulted in this test failing:
|
… github.com:JohnSnowLabs/spark-nlp into SPARKNLP-602-enable-annotation-audio-light-pipeline
@maziyarpanahi, yes I added the commit that solves that error |
…ng LightPipeline unit test in python
maziyarpanahi
approved these changes
Oct 11, 2022
…-annotation-audio-light-pipeline
Merged
KshitizGIT
deleted the
SPARKNLP-602-enable-annotation-audio-light-pipeline
branch
March 2, 2023 11:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change adds the required methods in Scala and Python to allow sending audio inputs as a collection of floats to
fullAnnotate
method inLightPipeline
.Motivation and Context
Currently
Wav2Vec2ForCTC
is the only available as a Spark transformer, users that rely on LightPipline for their processes cannot use this new annotator. By enabling this usage in LightPipeline users will be able to use it.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: