Fix knobs not updating vals on link (LMMS#4904)

JohannesLorenz · Dec 7, 2019 · 5ea869b · 5ea869b
1 parent 6351677
commit 5ea869b
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/include/AutomatableModel.h b/include/AutomatableModel.h
@@ -220,6 +220,7 @@ class EXPORT AutomatableModel : public Model, public JournallingObject
 		m_centerValue = centerVal;
 	}
 
+	//! link @p m1 and @p m2, let @p m1 take the values of @p m2
 	static void linkModels( AutomatableModel* m1, AutomatableModel* m2 );
 	static void unlinkModels( AutomatableModel* m1, AutomatableModel* m2 );
 

diff --git a/src/core/AutomatableModel.cpp b/src/core/AutomatableModel.cpp
@@ -443,8 +443,15 @@ void AutomatableModel::unlinkModel( AutomatableModel* model )
 
 void AutomatableModel::linkModels( AutomatableModel* model1, AutomatableModel* model2 )
 {
-		model1->linkModel( model2 );
-		model2->linkModel( model1 );
+	model1->linkModel( model2 );
+	model2->linkModel( model1 );
+	model1->m_value = model2->m_value;
+	if (model1->valueBuffer() && model2->valueBuffer())
+	{
+		std::copy_n(model2->valueBuffer()->data(),
+			model1->valueBuffer()->length(),
+			model1->valueBuffer()->data());
+	}
 }