Simplified the logic for showing/hiding MIDI controller tabs by intro…

…ducing a boolean variable
JoergAtGithub · Dec 30, 2024 · 1621866 · 1621866
1 parent e9ce649
commit 1621866
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/src/controllers/dlgprefcontroller.cpp b/src/controllers/dlgprefcontroller.cpp
@@ -778,15 +778,11 @@ void DlgPrefController::slotMappingSelected(int chosenIndex) {
     }
 
     // These tabs are only usable for MIDI controllers
-    if (m_pController->getDataRepresentationProtocol() == DataRepresentationProtocol::MIDI &&
-            !mappingFilePath.isEmpty()) {
-        m_ui.controllerTabs->setTabVisible(m_inputMappingsTabIndex, true);
-        m_ui.controllerTabs->setTabVisible(m_outputMappingsTabIndex, true);
-
-    } else {
-        m_ui.controllerTabs->setTabVisible(m_inputMappingsTabIndex, false);
-        m_ui.controllerTabs->setTabVisible(m_outputMappingsTabIndex, false);
-    }
+    bool showMidiTabs = m_pController->getDataRepresentationProtocol() ==
+                    DataRepresentationProtocol::MIDI &&
+            !mappingFilePath.isEmpty();
+    m_ui.controllerTabs->setTabVisible(m_inputMappingsTabIndex, showMidiTabs);
+    m_ui.controllerTabs->setTabVisible(m_outputMappingsTabIndex, showMidiTabs);
 
     // Hide the entire QTabWidget if all tabs are removed
     m_ui.controllerTabs->setVisible(getNumberOfVisibleTabs() > 0);