Scatter struct nulls when deserializing Presto wire format (facebooki…

…ncubator#7813) Summary: Pull Request resolved: facebookincubator#7813 Reviewed By: Yuhta Differential Revision: D51867634 Pulled By: oerling fbshipit-source-id: 71c59f5e8c152c72a3c76cf4fd6add0d28819974
Joe-Abraham · Dec 18, 2023 · aaaa079 · aaaa079
1 parent d3f0dc9
commit aaaa079
Show file tree

Hide file tree

Showing 4 changed files with 612 additions and 509 deletions.
diff --git a/velox/exec/SpillFile.cpp b/velox/exec/SpillFile.cpp
@@ -178,7 +178,7 @@ uint64_t SpillWriter::write(
     MicrosecondTimer timer(&timeUs);
     if (batch_ == nullptr) {
       serializer::presto::PrestoVectorSerde::PrestoOptions options = {
-          kDefaultUseLosslessTimestamp, compressionKind_};
+          kDefaultUseLosslessTimestamp, compressionKind_, true};
       batch_ = std::make_unique<VectorStreamGroup>(pool_);
       batch_->createStreamTree(
           std::static_pointer_cast<const RowType>(rows->type()),
@@ -294,7 +294,7 @@ SpillReadFile::SpillReadFile(
       numSortKeys_(numSortKeys),
       sortCompareFlags_(sortCompareFlags),
       compressionKind_(compressionKind),
-      readOptions_{kDefaultUseLosslessTimestamp, compressionKind_},
+      readOptions_{kDefaultUseLosslessTimestamp, compressionKind_, true},
       pool_(pool) {
   constexpr uint64_t kMaxReadBufferSize =
       (1 << 20) - AlignedBuffer::kPaddedSize; // 1MB - padding.