This repository has been archived by the owner on Oct 30, 2020. It is now read-only.
[Spike] Check for children more efficiently during clean-up #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2032725 to
1966e1e
Compare
seiffert
commented
May 11, 2017
| }}, | ||
| }, | ||
| }, | ||
| Limit: aws.Int64(2), |
There was a problem hiding this comment.
This was @TobiasBales's idea! ❤️
There was a problem hiding this comment.
I think you should document why the limit is 2 and not 1 (in a comment I'd guess)
There was a problem hiding this comment.
yes of course! This is just a spike to validate the idea 😉
|
Binaries built from this branch: linux_amd64.zip |
|
this is nowadays part of Vault: hashicorp#2722 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge, this PR needs to be cleaned up and then committed to
hashicorp/vault.