-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(folia): added folia support #292
Conversation
From the first request for Folia support:
I see this PR does not introduce any mitigation for the above concern. How does Folia handle inventory modification synchronization from players on different threads? |
From testing, I haven't found any discrepancies relative to removing or adding armor/tools to the player in or outside of the global region (nor if the player is in a separate region from the origin player) when experimenting with this build, even through my valiant attempts and with multiple accounts. So, from testing these changes directly, I couldn't really find anything that'd potentially break the synchronization of inventory contents. |
Gotcha. I'm still lightly concerned about it, but maybe the existing sync system moves the handling to the correct thread? I'm aware that there is some sync done in vanilla inventory operations, but I didn't think it was extensive enough to handle Folia-level async operations. I'll probably just put in a disclaimer about not having the capacity to test myself in the changelog. |
Of course and if issues arise, we can swiftly patch 'em. We just really couldn't find any with the amount of tested conducted thus far. Thank you for considering this PR! |
No description provided.