Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PyStubType for numpy's PyReadonlyArray #142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

unkcpz
Copy link

@unkcpz unkcpz commented Jan 21, 2025

The PyStubType for the `PyReadonlyArray was not support, I add it to the numpy.rs and it seems works for my case where the type is PyReadonlyArray.

@zao111222333
Copy link
Contributor

Hi, I want to participate to relf/egobox#237 as well, and here is my suggestion for this PR, we can reuse the PyArray's code as following:

impl<T: NumPyScalar + Element, D: Dimension> PyStubType for PyReadonlyArray<'_, T, D> {
    fn type_output() -> TypeInfo {
        PyArray::<T, D>::type_output()
    }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants