Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move to a new "Service" config format #182

Merged
merged 130 commits into from
Sep 4, 2024
Merged

refactor: move to a new "Service" config format #182

merged 130 commits into from
Sep 4, 2024

Conversation

sbruens
Copy link

@sbruens sbruens commented Jun 3, 2024 •
edited
Loading

We introduce a concept of a Service. Services listen on an address and accept a set of ciphers. This generalization allows us to move away from a single port->cipher map.

@sbruens sbruens requested a review from fortuna June 3, 2024 21:35
@sbruens sbruens marked this pull request as ready for review June 3, 2024 21:35
@sbruens sbruens requested a review from a team as a code owner June 3, 2024 21:35
@sbruens
Copy link
Author

sbruens commented Jun 3, 2024

@fortuna PTAL while I'm out. I'll pick it back up once I'm back next week.

juev
juev reviewed Jun 4, 2024
View reviewed changes
Copy link

@juev juev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very good point is that ports are now used as they are described in the configuration file.

cmd/outline-ss-server/config.go Outdated Show resolved Hide resolved
fortuna
fortuna reviewed Jun 10, 2024
View reviewed changes
cmd/outline-ss-server/config.go Outdated Show resolved Hide resolved
cmd/outline-ss-server/config.go Outdated Show resolved Hide resolved
cmd/outline-ss-server/config.go Outdated Show resolved Hide resolved
fortuna
fortuna requested changes Jun 10, 2024
View reviewed changes
net/address.go Outdated Show resolved Hide resolved
net/address.go Outdated Show resolved Hide resolved
net/address.go Outdated Show resolved Hide resolved
net/address.go Outdated Show resolved Hide resolved
cmd/outline-ss-server/config.go Outdated Show resolved Hide resolved
cmd/outline-ss-server/config.go Outdated Show resolved Hide resolved
cmd/outline-ss-server/main.go Outdated Show resolved Hide resolved
cmd/outline-ss-server/main.go Outdated Show resolved Hide resolved
cmd/outline-ss-server/main.go Outdated Show resolved Hide resolved
@sbruens sbruens requested review from fortuna and jyyi1 June 14, 2024 18:43
@sbruens sbruens force-pushed the sbruens/shared-listeners branch from 707bc35 to 80e5d49 Compare August 7, 2024 14:49
sbruens added 17 commits August 7, 2024 11:42
@sbruens
Use / in key instead of -.
aa00f2e
@sbruens
Return error from stopping listeners.
e658b90
@sbruens
Use channels to ensure virtualPacketConns get closed.
fede4d8
@sbruens
Add more test cases for packet listeners.
4730d74
@sbruens
Merge branch 'sbruens/shared-listeners' into sbruens/proxy
30bbdfa
@sbruens
Only log errors from stopping old configs.
458cf41
@sbruens
Remove the closed field from the virtual listeners.
81bf20e
@sbruens
Remove the RefCount.
53b1e96
@sbruens
Implement channel-based packet read for virtual connections.
8f9f1ea
@sbruens
Use a done channel.
1ac265d
@sbruens
Merge branch 'sbruens/shared-listeners' into sbruens/proxy
f5afdcb
@sbruens
Set listeners and onCloseFunc's to nil when closing.
1538a9a
@sbruens
Set onCloseFunc's to nil when closing.
4df0b9f
@sbruens
Fix race condition.
16feaf9
@sbruens
Add some benchmarks for listener manager.
288b88b
@sbruens
Merge branch 'master' into sbruens/shared-listeners
d688dd9
@sbruens
Merge branch 'sbruens/shared-listeners' into sbruens/proxy
c702159
Base automatically changed from sbruens/shared-listeners to master August 28, 2024 13:26
@sbruens
Copy link
Author

sbruens commented Aug 28, 2024

@fortuna PTAL now that the listener changes have been merged

@sbruens sbruens merged commit 9992735 into master Sep 4, 2024
5 checks passed
@sbruens sbruens deleted the sbruens/proxy branch September 4, 2024 19:30
@sbruens sbruens mentioned this pull request Jan 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juev juev juev left review comments

@fortuna fortuna fortuna approved these changes

@jyyi1 jyyi1 Awaiting requested review from jyyi1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbruens @fortuna @juev