feat(server): reduce metrics resources #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What do you think about keeping the TCP probes histogram but removing the location dimension? It seems like that should reduce the usage by a large factor without losing the visibility. |
|
@bemasc I restored the tcp probe metric, without location. Another look? |
Amirreza1396
approved these changes
Feb 2, 2023
| dataBytes *prometheus.CounterVec | ||
| timeToCipherMs *prometheus.HistogramVec | ||
| buildInfo *prometheus.GaugeVec | ||
| accessKeys prometheus.Gauge |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Peyman49
reviewed
Jun 16, 2023
| @@ -208,20 +208,20 @@ func isFound(accessKey string) string { | |||
| } | |||
|
|
|||
| // addIfNonZero helps avoid the creation of series that are always zero. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
locationfrom theshadowsocks_tcp_probestime series, which is the largest one.shadowsocks_data_bytes. We were creating 4 entries (each proxy leg) for every country that attempted to connect, even if they were unsuccessful connections. The metric was dominated by zeros.shadowsocks_data_bytesby removing the status and location. We don't need that for data limits. To enable country usage tracking, I introduceshadowsocks_data_bytes_per_location. To enable status tracking for UDP, I introduceshadowsocks_udp_packets_from_client_per_location. TCP already hadshadowsocks_connections_closedfor status tracking.