JT-83359 Enable back controlling shortcuts #7637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uts' on parent, removed in 473d554
|
@Hypnosphi Don't you remember if there was specific need to call |
vkrol
approved these changes
Aug 14, 2024
andrey-skl
added a commit
that referenced
this pull request
Aug 21, 2024
* RG-2293 Get rid of side effects in setState updater function of Select component (#7574) * 6.0.50 * RG-2462 switch sidebar and main background in dark theme (#7565) (cherry picked from commit 647dd76) * 6.0.51 * Support passing theme down via React Context (#7592) * 6.0.52 * RG-2420 chore: undeprecate "Badge" in 6.x version * Chore: export GLOBAL_DARK_CLASS_NAME constant [publish] * 6.0.53 * JT-83359 Enable back controlling shortcuts by having '.ring-js-shortcuts' on parent, removed in 473d554 (#7637) * RG-2473 don't unmount react root because it can be reused later (#7656) minor: log auth error * Revert "RG-2420 chore: undeprecate "Badge" in 6.x version" This reverts commit 580369f. --------- Co-authored-by: Veniamin Krol <153412+vkrol@users.noreply.github.com> Co-authored-by: JetBrains Ring UI Automation <npmjs-buildserver@jetbrains.com>
andrey-skl
added a commit
that referenced
this pull request
Sep 4, 2024
* RG-2293 Get rid of side effects in setState updater function of Select component (#7574) * 6.0.50 * RG-2462 switch sidebar and main background in dark theme (#7565) (cherry picked from commit 647dd76) * 6.0.51 * Support passing theme down via React Context (#7592) * 6.0.52 * RG-2420 chore: undeprecate "Badge" in 6.x version * Chore: export GLOBAL_DARK_CLASS_NAME constant [publish] * 6.0.53 * JT-83359 Enable back controlling shortcuts by having '.ring-js-shortcuts' on parent, removed in 473d554 (#7637) * RG-2473 don't unmount react root because it can be reused later (#7656) minor: log auth error * 6.0.54 * Revert "JT-83359 Enable back controlling shortcuts by having '.ring-js-shortcuts' on parent, removed in 473d554" This reverts commit 9192646. * 6.0.55 * Put page reload in timeout for USER_CHANGED event to let all other events to be called. JT-83975 related * 6.0.56 * Chore: add example with dialog with close button inside * Revert "RG-2420 chore: undeprecate "Badge" in 6.x version" This reverts commit 580369f. --------- Co-authored-by: Veniamin Krol <153412+vkrol@users.noreply.github.com> Co-authored-by: JetBrains Ring UI Automation <npmjs-buildserver@jetbrains.com>
andrey-skl
added a commit
that referenced
this pull request
Oct 21, 2024
* RG-2293 Get rid of side effects in setState updater function of Select component (#7574) * 6.0.50 * RG-2462 switch sidebar and main background in dark theme (#7565) (cherry picked from commit 647dd76) * 6.0.51 * Support passing theme down via React Context (#7592) * 6.0.52 * RG-2420 chore: undeprecate "Badge" in 6.x version * Chore: export GLOBAL_DARK_CLASS_NAME constant [publish] * 6.0.53 * JT-83359 Enable back controlling shortcuts by having '.ring-js-shortcuts' on parent, removed in 473d554 (#7637) * RG-2473 don't unmount react root because it can be reused later (#7656) minor: log auth error * 6.0.54 * Revert "JT-83359 Enable back controlling shortcuts by having '.ring-js-shortcuts' on parent, removed in 473d554" This reverts commit 9192646. * 6.0.55 * Put page reload in timeout for USER_CHANGED event to let all other events to be called. JT-83975 related * 6.0.56 * Chore: add example with dialog with close button inside * RG-2227 Clicking on a select label reopens the dropdown (cherry picked from commit a685a07) * chore: Prevent dialog scroll (#7710) * chore: Prevent dialog scroll * chore: preventBodyScroll should not be passed as a part of restProps * 6.0.57 * Add attributes prop to DatePicker button (#7727) Co-authored-by: Mikhail Cherviakov <mikhail.cherviakov@jetbrains.com> * 6.0.58 * [publish] fix breadcrumbs work with React.Fragment containers as a transparent containers reactjs/rfcs#61 * 6.0.59 * Revert "[publish] fix breadcrumbs work with React.Fragment containers as a transparent containers" This reverts commit 704bb21. * 6.0.60 * Fix Table colspan calculation when columns is passed as function * 6.0.61 * Get rid of unused Table maxColSpan prop * RG-2490 support moving cursor from anchor to tooltip (#7754) * RG-2490 support moving cursor from anchor to tooltip * RG-2490 use React for "mouseout" event * 6.0.62 * Check className in QueryAssist shouldComponentUpdate * 6.0.63 --------- Co-authored-by: Veniamin Krol <153412+vkrol@users.noreply.github.com> Co-authored-by: JetBrains Ring UI Automation <npmjs-buildserver@jetbrains.com> Co-authored-by: Filipp Riabchun <filipp.riabchun@jetbrains.com> Co-authored-by: Alexander Burkov <a.p.burkov@gmail.com> Co-authored-by: Mihail Ch. <pltnm239@gmail.com> Co-authored-by: Mikhail Cherviakov <mikhail.cherviakov@jetbrains.com> Co-authored-by: maksim.erekhinskii <maxim.erehinskiy@jetbrains.com> Co-authored-by: Veniamin Krol <veniamin.krol@jetbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by having '.ring-js-shortcuts' on parent, removed in 473d554